On Wed, May 13, 2009 at 11:00:45AM -0700, Bob Copeland wrote: > On Wed, May 13, 2009 at 1:20 PM, Luis R. Rodriguez > <lrodriguez@xxxxxxxxxxx> wrote: > > On Wed, May 13, 2009 at 2:53 AM, Johannes Berg > > <johannes@xxxxxxxxxxxxxxxx> wrote: > >> On Wed, 2009-05-13 at 05:20 -0400, Luis R. Rodriguez wrote: > >>> We inform the drivers so they can take appropriate actions during > >>> suspend for WoW support. > >> > >>> -static void ar9170_op_stop(struct ieee80211_hw *hw) > >>> +static void ar9170_op_stop(struct ieee80211_hw *hw, bool suspend) > > Just curious, why can't the bus suspend method just turn the radio back on? > You have to set up the wow parameters later anyway. That's possible too. > I think it'd be cleaner if the stack knew about WoW somehow rather than > doing stuff behind its back in the driver. Then suspend/resume could do > the right thing (e.g. ops->wow_enable() instead of stop) if the driver was > WoW-capable. Agreed, however ath9k is the only card I know how WoW works so far. If other devices would follow this logic then I think it makes sense to use something like a cfg callback for wow_enable() -- but then again this is only done for ath9k for suspend so doing it at suspend saves us a callback. Thoughts? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
