Hi, On Fri, Apr 24, 2009 at 03:58:20PM -0700, Greg KH wrote: > On Fri, Apr 24, 2009 at 07:03:29AM -0400, Forest Bond wrote: > > Hi Greg, > > > > On Sun, Apr 19, 2009 at 03:32:18PM -0700, Greg KH wrote: > > > On Sun, Apr 19, 2009 at 04:01:46PM -0400, Forest Bond wrote: > > > > On Sun, Apr 19, 2009 at 02:52:57PM -0500, Larry Finger wrote: > > > > > Forest Bond wrote: > > > > > > > > > > > > However, I did have a question: > > > > > > > > > > > > The vt6655 driver builds viawget.ko, and the vt6656 driver builds vntwusb.ko. > > > > > > Should the directories be named "viawget" and "vntwusb," respectively, or is it > > > > > > appropriate for them to be named "vt6655" and "vt6656"? > > > > > > > > > > Of course Greg has the final say, but I vote to keep the directories with the > > > > > vt6656 name and change the name of the driver, which is defined in the line > > > > > #define DEVICE_NAME "vntwusb" in file include/device_cfg.h in the vendor driver. > > > > > > > > This makes sense to me. I'll proceed this way for now. Greg, let me know if > > > > you'd prefer I didn't do this. > > > > > > No objection from me. > > > > The following git repository has a vt6655 branch and a vt6656 branch: > > > > http://www.alittletooquiet.net/media/code/vt665x.git > > > > The vt6655 branch contains pretty much all of the work I'll likely be able to do > > for that driver. The vt6656 branch needs more work. I've not gone farther than > > build-testing either, at this point. > > > > As I've mentioned before, some of this kind of work is really a bit outside my > > usual domain, so if you do look at it, I'd appreciate feedback. > > > > Feel free to make requests. > > Could you send it out as patches so it's easier to review? Yes, I would've preferred that but the first patch is >1MB, so I figured it might be more useful to point you to a git repository, rather than send out a compressed patch. I can send it out uncompressed if you prefer, or I can just send all but the first patch (which only copies files from the upstream archive, anyway). -Forest -- Forest Bond http://www.alittletooquiet.net http://www.pytagsfs.org
Attachment:
signature.asc
Description: Digital signature
