Search Linux Wireless

Re: [RFT/RFC] rtl8187: Implement TX/RX blink for LED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hin-Tak Leung wrote:
> On Sat, Apr 11, 2009 at 5:23 AM, Hin-Tak Leung <hintak.leung@xxxxxxxxx> wrote:
> 
> Oh, I forgot to mention that to test this code against
> compat-wireless, appending "CONFIG_RTL8187_LEDS=y" to config.mk does
> the job.
> 
> I am wonder if we actually needs an extra Kconfig for this - at least
> in my case, the code has no ill effect with device which hasn't got an
> RX/TX LED. (other than possibly a small theoretical performance loss
> from do extra non-useful work).

I do have to compile the LED code only if the kernel has support for them,
otherwise the registration entry points would be missing. The necessary
conditions would be more complicated, thus I put them in one place in the
Kconfig and let the source only be dependent on CONFIG_RTL8187_LEDS.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux