On Thu, Apr 9, 2009 at 5:23 AM, Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote:
> The following patch implements some control over the LED on RTL8187B and
> RTL8187L devices. Triggers are registered for TX and RX. Whenever the
> trigger event occurs, the LED is turned off for 1/20 second, then turned
> back on.
On the LED functionality - the LED on my laptop actually works rather
differently under windows vs under linux.
On windows it is tied to the hardware switch, and the windows driver
depends on the state of the hardware switch.
The linux driver's behavior has no relationship with the LED what so
ever. (I suppose it might blink under windows but I don't know for
sure).
> Please test and comment.
I'll have a little go at it later, but a few comments below.
> Index: wireless-testing/drivers/net/wireless/rtl818x/rtl8187_leds.c
> ===================================================================
> --- /dev/null
> +++ wireless-testing/drivers/net/wireless/rtl818x/rtl8187_leds.c
> + * Based on the r8187 driver, which is:
> + * Copyright 2005 Andrea Merello <andreamrl@xxxxxxxxxx>, et al.
> Index: wireless-testing/drivers/net/wireless/rtl818x/rtl8187_leds.h
> ===================================================================
> + * Based on the r8187 driver, which is:
> + * Copyright 2005 Andrea Merello <andreamrl@xxxxxxxxxx>, et al.
I found these two comments a bit odd, so I went back to the vendor
driver code to have a look.
The LED code is AFAIK a rather new addition to the vendor driver,
within the 2008, I think. It is in
0708.2008 but not in 0822.2007, and does not seem to be in 0125.2008
driver either.
The two new LED related files in 0708.2008 have these headers:
--------------------------------------------------------------------------------------------------
/*++
Copyright (c) Realtek Semiconductor Corp. All rights reserved.
Module Name:
r8187_led.c
Abstract:
RTL8187 LED control functions
Major Change History:
When Who What
---------- --------------- -------------------------------
2006-09-07 Xiong Created
Notes:
--*/
/*++
Copyright (c) Microsoft Corporation. All rights reserved.
Module Name:
r8187_led.h
Abstract:
definitions and stuctures for rtl8187 led control.
Major Change History:
When Who What
---------- ------ ----------------------------------------------
2006-09-07 Xiong Created
Notes:
--*/
-------------------------------------------------------------------------------------------------
I am slightly worried about the microsoft copyright in the latter :-),
but presumably it is a visual studio or dev tool artefact :-).
> --- wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8187_rtl8225.c
> +++ wireless-testing/drivers/net/wireless/rtl818x/rtl8187_rtl8225.c
> @@ -18,6 +18,7 @@
>
> #include <linux/init.h>
> #include <linux/usb.h>
> +#include <linux/eeprom_93cx6.h>
> #include <net/mac80211.h>
>
> #include "rtl8187.h"
This trunk seems to be redundant - why would a new include be needed
for no code addition?
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
