Alina Friedrichsen wrote:
> Maybe because the scanning code was changed? But I have discovered this bug
> at the end of the last year before the scanning code was changed the last time.
Not sure, but this is a bug for sure.
> > And it can be fixed by
> > making use of the scan start/stop mac80211 callbacks.
>
> I think a much cleaner way would be if the ath9k_hw_write_associd() honor the FIF_BCN_PRBRESP_PROMISC flag and determine with it if sc->curbssid should be set or ath_bcast_mac. So the the old sc->curbssid setting is saved. And then remove the following code...
>
> if (*total_flags & FIF_BCN_PRBRESP_PROMISC) {
> memcpy(sc->curbssid, ath_bcast_mac, ETH_ALEN);
> sc->curaid = 0;
>
> ...so that ath9k_hw_write_associd() is called if the FIF_BCN_PRBRESP_PROMISC is cleared at the end of the scanning, too. So that it can set the BSSID in the hardware back to sc->curbssid.
>
Sure, either way works, since FIF_BCN_PRBRESP_PROMISC is set only during scanning
anyway.
Sujith
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
