Search Linux Wireless

Re: [Orinoco-devel] [PATCH] orinoco: checkpatch cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2009-01-25 at 23:08 +0300, Andrey Borzenkov wrote:
> On 25 января 2009 22:59:35 Johannes Berg wrote:
> 
> > unfortunately, your patch was line-wrapped. Cf.
> > Documentation/email-clients.txt
> >
> 
> This should be updated to indicate that kmail from KDE4 is broken. I 
> suspected that but so far it worked.

I suggest that you try STGit.  It sends patches by itself.

Please run the patch itself through checkpatch.  It finds two errors:

ERROR: trailing statements should be on next line
#163: FILE: drivers/net/wireless/orinoco/hermes.c:65:
+                       printk(stuff); } while (0)
+                       printk(stuff); } while (0)
ERROR: do not use assignment in if condition
#698: FILE: drivers/net/wireless/orinoco/orinoco_cs.c:167:
+       if ((last_ret = (ret)) != 0) \

total: 2 errors, 0 warnings, 786 lines checked

-- 
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux