Search Linux Wireless

Re: [PATCH 2/2] iwl3945: Remove unused variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Donnerstag, 22. Januar 2009 schrieb Tomas Winkler:
> On Thu, Jan 22, 2009 at 12:44 PM, Helmut Schaa
> <helmut.schaa@xxxxxxxxxxxxxx> wrote:
> > Am Mittwoch, 21. Januar 2009 schrieb John W. Linville:
> >> On Mon, Jan 19, 2009 at 09:55:32AM +0100, Helmut Schaa wrote:
> >> > Fix the following warnings in iwl-3945-rs.c by removing unused variables.
> >> >
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'iwl3945_rate_scale_flush_windows':
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c:186: warning: unused variable 'priv'
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'iwl3945_bg_rate_scale_flush':
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c:219: warning: unused variable 'priv'
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'iwl3945_collect_tx_data':
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c:293: warning: unused variable 'priv'
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'rs_free_sta':
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c:441: warning: unused variable 'priv'
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'iwl3945_get_adjacent_rate':
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c:559: warning: unused variable 'priv'
> >> >
> >> > Signed-off-by: Helmut Schaa <helmut.schaa@xxxxxxxxxxxxxx>
> >>
> >> With this applied, I get these:
> >>
> >>   CC [M]  drivers/net/wireless/iwlwifi/iwl-3945-rs.o
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'iwl3945_rate_scale_flush_windows':
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:199: error: 'priv' undeclared (first use in this function)
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:199: error: (Each undeclared identifier is reported only once
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:199: error: for each function it appears in.)
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'iwl3945_bg_rate_scale_flush':
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:222: error: 'priv' undeclared (first use in this function)
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'iwl3945_collect_tx_data':
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:293: error: 'priv' undeclared (first use in this function)
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'rs_free_sta':
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:441: error: 'priv' undeclared (first use in this function)
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'iwl3945_get_adjacent_rate':
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:594: error: 'priv' undeclared (first use in this function)
> >> make[2]: *** [drivers/net/wireless/iwlwifi/iwl-3945-rs.o] Error 1
> >> make[1]: *** [drivers/net/wireless/iwlwifi] Error 2
> >> make: *** [drivers/net/wireless/] Error 2
> >>
> >> Dropping...
> >
> > Ah, sorry for that. I compiled without CONFIG_IWL_DEBUG. Instead of removing
> > these lines they should be surrounded by an CONFIG_IWL_DEBUG check. I'll send
> > that soon.
> 
> Please use
> struct iwl_priv *priv __maybe_unused priv;
> look  at  in iwl-agn-rs.c

Will do. Thanks for the hint.

Helmut
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux