Christian Lamparter wrote: > On Thursday 22 January 2009 16:52:44 Artur Skawina wrote: >> Christian Lamparter wrote: >>> On Thursday 22 January 2009 06:40:56 Artur Skawina wrote: >>> was this with your patch to use rx_refills urb pool for tx, or without? >> just your patch plus the fixes that i needed to get it to work, all >> of them were in that email. The subject said RFT... ;) >> [the line #s were off, because of some extra printks logging the queue len] >> > all right, could you please put a commit message in your mail as well? I thought you had already merged the changes, but i see you only took the first hunk. There's no point in splitting the commit, as the intermediate result wouldn't work. You can add my s-o-b, if you feel that's necessary. This last version seems fine, just one thing: I can't convince myself that not queuing the work after an urb fails with urb->status==true is safe -- what if some temporary error condition causes the rx queue to drain? Nothing will resubmit the urbs. Wouldn't a usb_poison_anchored_urbs() instead of usb_kill_anchored_urbs() in p54u_free_urbs() prevent p54u_rx_refill from resubmitting, and that early return in the completion could then go? Or did i miss a case where it's needed, other than stop()? artur -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
