2009/1/22 Bob Copeland <me@xxxxxxxxxxxxxxx>: > > Point is taken, although if gain calibration does fail, can we do anything > about it other than log an error? Looping forever in reset() is probably > not a good idea. > We can check if the bit got cleared on next phy_calibrate and if it hasn't we can reschedule it or schedule a reset. > OTOH, I'm pretty sure miscalibrated phy is responsible for all the > "unsupported jumbo" errors; I hexdumped some of those and they're all > just noise. > Don't we get a phy error interrupt ? I haven't looked into this ;-( > (Side note, any reason we call reset() from ath5k_config_interface? > We're not changing channels, just setting the bssid.) > Hmm, i'll check that and come back to you, i think we have to re-initialize PCU but i'm not sure. Also if it's supposed to set the bssid on a virtual if, we also have to set bssid mask to allow all configured bssids for all vifs. -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html