On Tuesday 20 January 2009 21:18:48 Artur Skawina wrote: > Christian Lamparter wrote: > > On Tuesday 20 January 2009 00:17:13 Artur Skawina wrote: > > if your device finally works. (Well "works" is maybe a bit too much, > > as you'll probably run into other bugs, e.g truesize bug or the "shot rc", or > > more problems with powersaving station that only have apsd). > > It seems to work quite well, i'm seeing the occasional truesize warning and > haven't yet figured out why the client won't reconnect before hostapds > ap_max_inactivity timeout triggers, but other than that everything seems fine. So, p54usb first generation needs the ZERO_PACKET flag as well? (e.g a patch like the attached p54usb-net2280-zeropacket.diff ?) Regards, Chr
diff --git a/drivers/net/wireless/p54/p54usb.c b/drivers/net/wireless/p54/p54usb.c index da3e918..4617bc2 100644 --- a/drivers/net/wireless/p54/p54usb.c +++ b/drivers/net/wireless/p54/p54usb.c @@ -332,12 +332,13 @@ static void p54u_tx_net2280(struct ieee80211_hw *dev, struct sk_buff *skb) * free what's inside the transfer_buffer after the callback routine * has completed. */ - int_urb->transfer_flags |= URB_FREE_BUFFER; + int_urb->transfer_flags |= URB_FREE_BUFFER | URB_ZERO_PACKET; usb_fill_bulk_urb(data_urb, priv->udev, usb_sndbulkpipe(priv->udev, P54U_PIPE_DATA), hdr, skb->len + sizeof(*hdr), FREE_AFTER_TX(skb) ? p54u_tx_cb : p54u_tx_dummy_cb, skb); + data_urb->transfer_flags |= URB_ZERO_PACKET; usb_anchor_urb(int_urb, &priv->submitted); err = usb_submit_urb(int_urb, GFP_ATOMIC);
