Artur Skawina wrote: > Christian Lamparter wrote: >> On Monday 19 January 2009 22:53:03 Artur Skawina wrote: >>> We can move the FREE_AFTER_TX(skb) check from the completion to the submission >>> path, right? Then find a way to do the pull _before_ giving away the skbs. >>> I can't shutdown the machine where i can reproduce this today, so it will have >>> to wait until at least tomorrow. >>> >>> artur >> Like this? >> > yes, that's what i was thinking. Will FREE_AFTER_TX(skb) be false for all skbs > that are dropped in p54_rx_frame_sent()? > Also most of the push/pull business in completions can probably go, we just have to set > up the pointers right on submission, ie transfer the rx header into the headroom, then > no skb manipulations in completions should be needed, and these kind of races should > be harmless. I only looked at the FREE_AFTER_TX(skb) part and completely missed that you had already removed the pull, sorry. artur -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
