On Fri, Jan 16, 2009 at 12:35:01PM -0800, Johannes Berg wrote: > On Fri, 2009-01-16 at 08:32 -0800, Luis R. Rodriguez wrote: > > > > > - chan->flags = flags | map_regdom_flags(reg_rule->flags); > > > > + rule_flags = map_regdom_flags(reg_rule->flags); > > > > + if (flags & IEEE80211_CHAN_DISABLED) > > > > + chan->flags = IEEE80211_CHAN_DISABLED; > > > > + else > > > > + chan->flags = flags | rule_flags; > > > > > > but why bother with more complicated code when adding a few more flags > > > doesn't hurt? > > > > I don't see these few lines as complicated really, but if you don't like them > > that's fine. We can also fix this in userspace so that disable|radar|no-ibss > > doesn't show up. I frankly think its pointless to keep them though. > > It's not exactly complicated, but I bet at some point we'll scratch our > heads why we did it ;) I can put a note, if that helps, or are you strongly opposed to this? :) Just an itch to scratch really, have you seen the output of iwlist on disabled channels? It can get long on radar/no-ibss channels. We can also handle this in userspace but seems pointles if the channels is disabled. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
