Search Linux Wireless

Re: [PATCH 07/13] cfg80211: only export disable flag on channel disablement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2009-01-16 at 08:32 -0800, Luis R. Rodriguez wrote:

> > > -	chan->flags = flags | map_regdom_flags(reg_rule->flags);
> > > +	rule_flags = map_regdom_flags(reg_rule->flags);
> > > +	if (flags & IEEE80211_CHAN_DISABLED)
> > > +		chan->flags = IEEE80211_CHAN_DISABLED;
> > > +	else
> > > +		chan->flags = flags | rule_flags;
> > 
> > but why bother with more complicated code when adding a few more flags
> > doesn't hurt?
> 
> I don't see these few lines as complicated really, but if you don't like them
> that's fine. We can also fix this in userspace so that disable|radar|no-ibss
> doesn't show up. I frankly think its pointless to keep them though.

It's not exactly complicated, but I bet at some point we'll scratch our
heads why we did it ;)

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux