"Bob Copeland" <me@xxxxxxxxxxxxxxx> writes: > On Fri, 09 Jan 2009 18:17:41 +0200, Kalle Valo wrote >> I read it. Adding "or NETDEV_TX_BUSY if it fails" is just confusing, >> better to state that it just should not fail. > > Fair enough, but the state of things today is some drivers do. > Yes, we're guilty of that in ath5k and it should be fixed. But like > ->config(), if the callback should never ever fail, then returning > an error code at all is pretty suspect. Yes, that's why it's already better to deny this kind of usage in documentation already now. > Would this be better? > > "This function should return NETDEV_TX_OK except in very limited cases." > > Then when someone asks which cases, you say "none"... That's better. Thanks for doing this. It's very important to document the return values, especially for the people not familiar with mac80211. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
