Bob Copeland <me@xxxxxxxxxxxxxxx> writes:
> On Tue, Jan 06, 2009 at 02:00:59PM +0100, Johannes Berg wrote:
>> I guess it should, want to send a patch?
>
> Some of the return values were already documented in the ops comment,
> and others like set_key() elsewhere. Here are more, though I guessed
> on a couple of them...
>
> From: Bob Copeland <me@xxxxxxxxxxxxxxx>
> Date: Thu, 8 Jan 2009 21:00:34 -0500
> Subject: [PATCH] mac80211: document return codes from ops callbacks
>
> For any callbacks in ieee80211_ops, specify what values the return
> codes represent. While at it, fix a couple of capitalization and
> punctuation differences.
>
> Signed-off-by: Bob Copeland <me@xxxxxxxxxxxxxxx>
> ---
> include/net/mac80211.h | 14 ++++++++++++--
> 1 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/include/net/mac80211.h b/include/net/mac80211.h
> index b7b9014..903dade 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -1170,6 +1170,7 @@ enum ieee80211_ampdu_mlme_action {
> * configuration in the TX control data. This handler should,
> * preferably, never fail and stop queues appropriately, more
> * importantly, however, it must never fail for A-MPDU-queues.
> + * Returns NETDEV_TX_OK, or NETDEV_TX_BUSY if it fails.
> * Must be implemented and atomic.
Based on discussion from netdev I have understood that NETDEV_TX_BUSY
is not recommended, it's better to stop the queue already earlier,
drop the frame or store the skb somewhere else temporarily. Johannes,
have I understood this correctly?
It would be nice to have this documented here.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
