"Bob Copeland" <me@xxxxxxxxxxxxxxx> writes:
> On Fri, 09 Jan 2009 10:13:56 +0200, Kalle Valo wrote
>> > @@ -1170,6 +1170,7 @@ enum ieee80211_ampdu_mlme_action {
>> > * configuration in the TX control data. This handler should,
>> > * preferably, never fail and stop queues appropriately, more
>> > * importantly, however, it must never fail for A-MPDU-queues.
>> > + * Returns NETDEV_TX_OK, or NETDEV_TX_BUSY if it fails.
>> > * Must be implemented and atomic.
>>
>> Based on discussion from netdev I have understood that NETDEV_TX_BUSY
>> is not recommended, it's better to stop the queue already earlier,
>> drop the frame or store the skb somewhere else temporarily. Johannes,
>> have I understood this correctly?
>>
>> It would be nice to have this documented here.
>
> Read the sentence before the added line :-)
I read it. Adding "or NETDEV_TX_BUSY if it fails" is just confusing,
better to state that it just should not fail.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
