Martin Kaistra <martin.kaistra@xxxxxxxxxxxxx> wrote: > Am 03.02.25 um 03:40 schrieb Ping-Ke Shih: > > Ezra Buehler <ezra@xxxxxxxx> wrote: > > > >> From: Ezra Buehler <ezra.buehler@xxxxxxxxxxxxxxxxxx> > >> > >> This allows the driver to be used in wireless access point mode on the > >> AT91SAM9G25-based GARDENA smart Gateway. > >> > >> Unfortunately, the data throughput in AP mode appears to be lower than > >> with the vendor driver (or in STA mode). Especially when sending, the > >> data rate is significantly lower. My measurements performed with iperf3 > >> and an Edimax EW-7811Un (VID: 7392, PID: 7811) showed a maximum TX rate > >> of about 4 Mbits/sec compared to the ~24 Mbits/sec measured with the > >> rtl8192cu driver. > >> > >> Although the performance might be good enough for our use case, this is > >> something that should be further looked into. > >> > >> Signed-off-by: Ezra Buehler <ezra.buehler@xxxxxxxxxxxxxxxxxx> > > > > 1 patch(es) applied to rtw-next branch of rtw.git, thanks. > > Is there a reason for not setting macid in rtl8xxxu_fill_txdesc_v1() and > rtl8xxxu_update_rate_mask() like it was done for the gen2 case? rtl8xxxu_fill_txdesc_v3() doesn't fill macid neither. Quickly search for the code filling tx desc [1]. I think we can have a #define TXDESC32_MACID_MASK GENMASK(4, 0) The h2c command format of rtl8xxxu_update_rate_mask() seemingly should be equal to rtl8192c_set_raid_cmd() [2], but not. Can anyone help to spin patches and test if it works? [1] https://github.com/lwfinger/rtl8192cu/blob/master/hal/rtl8192cu_xmit.c#L257 [2] https://github.com/lwfinger/rtl8192cu/blob/master/hal/rtl8192c_cmd.c#L201
