On 1/29/2025 1:24 AM, Nicolas Escande wrote:
> Arf I can see that the commit format is wrong but I wonder why checkpatch didn't
> arn me. Do I need more options set on the cmdline ?
>
> scripts/checkpatch.pl mail/0001-wifi-ath11k-remove-extra-rssi-update-in-ath11k_dp_rx.patch
> total: 0 errors, 0 warnings, 0 checks, 8 lines checked
>
> mail/0001-wifi-ath11k-remove-extra-rssi-update-in-ath11k_dp_rx.patch has no obvious style problems and is ready for submission.
Are you running checkpatch from within a kernel tree? Looking at the code:
($id, $description) = git_commit_info($orig_commit,
$id, $orig_desc);
if (defined($id) &&
($short || $long || $space || $case || ($orig_desc ne $description) || !$has_quotes) &&
$last_git_commit_id_linenr != $linenr - 1) {
ERROR("GIT_COMMIT_ID",
"Please use git commit description style 'commit <12+ chars of sha1> (\"<title line>\")' - ie: '${init_char}ommit $id (\"$description\")'\n" . $herectx);
}
So it will only report the problem if it can find the commit in git so that it
can provide the correct id and description.
/jeff
