On 1/17/2025 10:19 AM, Nicolas Escande wrote:
> Commit b205ce4c266c (ath11k: support avg signal in station dump) added an
I'll fixup this reference to address the checkpatch error:
ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit b205ce4c266c ("ath11k: support avg signal in station dump")'
total: 1 errors, 0 warnings, 0 checks, 8 lines checked
> extra assignment of arsta->rssi_comb in ath11k_dp_rx_update_peer_stats
> when it added the average rssi support. So lets keeps only one by removing
> the legacy assignment so the two statements about rssi stay next to each
> other. Compile tested only.
>
> Signed-off-by: Nicolas Escande <nico.escande@xxxxxxxxx>
> ---
> drivers/net/wireless/ath/ath11k/dp_rx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
> index 029ecf51c9efd..24774cba9823b 100644
> --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
> @@ -2831,8 +2831,6 @@ static void ath11k_dp_rx_update_peer_stats(struct ath11k_sta *arsta,
> rx_stats->dcm_count += ppdu_info->dcm;
> rx_stats->ru_alloc_cnt[ppdu_info->ru_alloc] += num_msdu;
>
> - arsta->rssi_comb = ppdu_info->rssi_comb;
> -
> BUILD_BUG_ON(ARRAY_SIZE(arsta->chain_signal) >
> ARRAY_SIZE(ppdu_info->rssi_chain_pri20));
>
