On Tue Jan 28, 2025 at 11:29 PM CET, Jeff Johnson wrote:
> On 1/17/2025 10:19 AM, Nicolas Escande wrote:
>> Commit b205ce4c266c (ath11k: support avg signal in station dump) added an
>
> I'll fixup this reference to address the checkpatch error:
> ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit b205ce4c266c ("ath11k: support avg signal in station dump")'
> total: 1 errors, 0 warnings, 0 checks, 8 lines checked
Arf I can see that the commit format is wrong but I wonder why checkpatch didn't
arn me. Do I need more options set on the cmdline ?
scripts/checkpatch.pl mail/0001-wifi-ath11k-remove-extra-rssi-update-in-ath11k_dp_rx.patch
total: 0 errors, 0 warnings, 0 checks, 8 lines checked
mail/0001-wifi-ath11k-remove-extra-rssi-update-in-ath11k_dp_rx.patch has no obvious style problems and is ready for submission.
>
>> extra assignment of arsta->rssi_comb in ath11k_dp_rx_update_peer_stats
>> when it added the average rssi support. So lets keeps only one by removing
>> the legacy assignment so the two statements about rssi stay next to each
>> other. Compile tested only.
>>
>> Signed-off-by: Nicolas Escande <nico.escande@xxxxxxxxx>
