On 1/28/2025 2:29 PM, Jeff Johnson wrote: > On 1/17/2025 10:19 AM, Nicolas Escande wrote: >> Commit b205ce4c266c (ath11k: support avg signal in station dump) added an > > I'll fixup this reference to address the checkpatch error: > ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit b205ce4c266c ("ath11k: support avg signal in station dump")' > total: 1 errors, 0 warnings, 0 checks, 8 lines checked > >> extra assignment of arsta->rssi_comb in ath11k_dp_rx_update_peer_stats >> when it added the average rssi support. So lets keeps only one by removing >> the legacy assignment so the two statements about rssi stay next to each >> other. Compile tested only. I actually made three fixups, please check: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=7946ec554fbea5db9a3aedb7087f0eb9e3749abc 1) commit reference 2) add () to function name 3) lets => let's