Search Linux Wireless

Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Hongbo Li <lihongbo22@xxxxxxxxxx>
Subject: Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code
From: David Howells <dhowells@xxxxxxxxxx>
Date: Sat, 24 Aug 2024 13:06:55 +0100
Cc: dhowells@xxxxxxxxxx, johannes@xxxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, edumazet@xxxxxxxxxx, kuba@xxxxxxxxxx, pabeni@xxxxxxxxxx, allison.henderson@xxxxxxxxxx, dsahern@xxxxxxxxxx, pshelar@xxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, rds-devel@xxxxxxxxxxxxxx, dccp@xxxxxxxxxxxxxxx, dev@xxxxxxxxxxxxxxx, linux-afs@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20240824074033.2134514-8-lihongbo22@huawei.com>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
References: <20240824074033.2134514-8-lihongbo22@huawei.com> <20240824074033.2134514-1-lihongbo22@huawei.com>

Hongbo Li <lihongbo22@xxxxxxxxxx> wrote:

> -	summary.ack_reason = (sp->ack.reason < RXRPC_ACK__INVALID ?
> -			      sp->ack.reason : RXRPC_ACK__INVALID);
> +	summary.ack_reason = min(sp->ack.reason, RXRPC_ACK__INVALID);

Can you use umin() rather than min(), please?

Thanks,
David

Follow-Ups:
- Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code
  - From: David Howells
- Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code
  - From: Hongbo Li
- Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code
  - From: Hongbo Li

References:
- [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code
  - From: Hongbo Li
- [PATCH net-next 0/8] Use max/min to simplify the code
  - From: Hongbo Li

Prev by Date: [PATCH -next,v2] wifi: mac80211: remove redundant unlikely() around IS_ERR()
Next by Date: Re: [PATCH v2 2/4] wifi: wilc1000: Fold wilc_get_chipid() into wlan.c
Previous by thread: Re: [PATCH net-next 4/8] net/core: Use min()/max() to simplify the code
Next by thread: Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Wireless Regulations] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]