Search Linux Wireless

Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Howells <dhowells@xxxxxxxxxx>
Subject: Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code
From: Hongbo Li <lihongbo22@xxxxxxxxxx>
Date: Mon, 26 Aug 2024 10:50:03 +0800
Cc: <johannes@xxxxxxxxxxxxxxxx>, <davem@xxxxxxxxxxxxx>, <edumazet@xxxxxxxxxx>, <kuba@xxxxxxxxxx>, <pabeni@xxxxxxxxxx>, <allison.henderson@xxxxxxxxxx>, <dsahern@xxxxxxxxxx>, <pshelar@xxxxxxx>, <linux-wireless@xxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <rds-devel@xxxxxxxxxxxxxx>, <dccp@xxxxxxxxxxxxxxx>, <dev@xxxxxxxxxxxxxxx>, <linux-afs@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <563923.1724501215@warthog.procyon.org.uk>
References: <20240824074033.2134514-8-lihongbo22@huawei.com> <20240824074033.2134514-1-lihongbo22@huawei.com> <563923.1724501215@warthog.procyon.org.uk>
User-agent: Mozilla Thunderbird



On 2024/8/24 20:06, David Howells wrote:

Hongbo Li <lihongbo22@xxxxxxxxxx> wrote:

-	summary.ack_reason = (sp->ack.reason < RXRPC_ACK__INVALID ?
-			      sp->ack.reason : RXRPC_ACK__INVALID);
+	summary.ack_reason = min(sp->ack.reason, RXRPC_ACK__INVALID);


Can you use umin() rather than min(), please?

I see reason is u8, so may I use min_t(u8, sp->ack.reason,RXRPC_ACK__INVALID)?


Thanks,
Hongbo

Thanks,
David

Follow-Ups:
- Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code
  - From: Simon Horman

References:
- [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code
  - From: Hongbo Li
- [PATCH net-next 0/8] Use max/min to simplify the code
  - From: Hongbo Li
- Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code
  - From: David Howells

Prev by Date: Re: [EXT] Re: [PATCH v2 00/43] wifi: nxpwifi: create nxpwifi to support iw61x
Next by Date: RE: [EXT] Re: [PATCH v2 00/43] wifi: nxpwifi: create nxpwifi to support iw61x
Previous by thread: Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code
Next by thread: Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Wireless Regulations] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]