On Sat, Aug 24, 2024 at 03:40:29PM +0800, Hongbo Li wrote: > Let's use min()/max() to simplify the code and fix the > Coccinelle/coccicheck warning. > > Signed-off-by: Hongbo Li <lihongbo22@xxxxxxxxxx> ... > diff --git a/net/core/sock.c b/net/core/sock.c > index bbe4c58470c3..c9910f48903f 100644 > --- a/net/core/sock.c > +++ b/net/core/sock.c > @@ -3800,7 +3800,7 @@ int sock_prot_inuse_get(struct net *net, struct proto *prot) > for_each_possible_cpu(cpu) > res += per_cpu_ptr(net->core.prot_inuse, cpu)->val[idx]; > > - return res >= 0 ? res : 0; > + return max(res, 0); > } > EXPORT_SYMBOL_GPL(sock_prot_inuse_get); As per my comment on 2/8 [*], I think you should drop this hunk. [*] https://lore.kernel.org/all/20240828135310.GC1368797@xxxxxxxxxx/
