On Sunday 07 December 2008 18:39:38 Johannes Berg wrote: > Can you rename those too to NL80211_RATE_INFO_*? That way we can use > them for other things later. > > But this looks good to me now. I have splitted the patch into two parts so a better review is possible without deciding if we put the total bandwith into nl80211 or not. Changes since v1: - removed noise and quality from station info in NL80211 - added bandwith to station info in NL80211 - changed name of patch file to nl80211ext_v2.patch Changes since v2: - added kernel comment lines for new fields/enums - changed name of "bandwith" field to tx_bitrate Changes since v3: - added rx_bitrate to station info and sta_info - remember bitrate of last received unicast packet to this station - decode 802.11n MCS index for nl80211 (maybe this should be ported to WEXT too ?) Changes since v4: - added tx_bitrate_flags adn tx_bitrate_mcs field to station info - added flags for 40Mhz and small guard interval to NL80211 station info - added mcs field to NL80211 station info Changes since v5: - remove rx_bitrate from patch until we get a sane way to learn the details of received 802.11n packages -replace 802.11n bitrate arrays with calculation based on basic rates - pushed txrate nl80211 stationinfo into nested attribute - created station_info_rate_flags enum to save bitrate flags in station_info - cleanup of kerneldoc Changes since v6: - removed mcs index to bitrate conversion - push station info bitrate into substructure - renamed "total" bitrate into "legacy" - some code cleanup Changes since v7: - corrected a small type in nl80211 mcs representation - splitted patch into two parts TODO: - tests with real 802.11n hardware - more tests with 802.11abg hardware Henning
Attachment:
signature.asc
Description: This is a digitally signed message part.
