On Sat, 2008-12-06 at 16:03 +0100, Henning Rogge wrote: > > can you please move the rate parts into a new struct, so we can use > > tx.flags, tx.mcs etc. and later just need to add a second instance of > > the struct for rx > > struct bitrate_info ? > or maybe > struct cfg80211_bitrate_info ? Either one is fine I guess. > > Also, if we really really need this information (I still don't see why > > the kernel has to calculate it) then it should be in cfg80211 not > > mac80211 so other drivers could potentially make use of it. Personally, > > I'd just leave it out though. > Hmm... is "cfg.c" not part of cfg80211 ? No, cfg.c is part of mac80211, it's mac80211's code to interact with cfg80211, it won't be called for non-mac80211 drivers. > We need the "total bitrate" for 802.11abg rates. They have no mcs rates. > The "legacy index" for non 802.11n bitrates points to a hw specific "band" > array, so I don't think we can export it to userspace as an index. But we can name it _legacy and put the bitrate there in units of 100kbps, and leave it out for MCS rates then. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
