On Thu, Oct 19, 2023 at 04:33:02PM +0300, Kalle Valo wrote:
> Shiji Yang <yangshiji66@xxxxxxxxxxx> writes:
>
> > On Thu, 19 Oct 2023 07:00:30 +0000, Kalle Valo wrote:
> >
> >>Shiji Yang <yangshiji66@xxxxxxxxxxx> wrote:
> >>
> >>> The watchdog function is broken on rt2800 series SoCs. This patch
> >>> fixes the incorrect watchdog logic to make it work again.
> >>>
> >>> 1. Update current wdt queue index if it's not equal to the previous
> >>> index. Watchdog compares the current and previous queue index to
> >>> judge if the queue hung.
> >>> 2. Make sure hung_{rx,tx} 'true' status won't be override by the
> >>> normal queue. Any queue hangs should trigger a reset action.
> >>> 3. Clear the watchdog counter of all queues before resetting the
> >>> hardware. This change may help to avoid the reset loop.
> >>> 4. Change hang check function return type to bool as we only need
> >>> to return two status, yes or no.
> >>>
> >>> Signed-off-by: Shiji Yang <yangshiji66@xxxxxxxxxxx>
Acked-by: Stanislaw Gruszka <stf_xl@xxxxx>
> >>Is this patch ok to take?
> >
> >
> > Hi! I think it's ready. I've been testing it for a few weeks.
>
> That question was more towards maintainers Stanislaw, Helmut and other
> reviewers :)
>
> That reminds me, is Helmut still maintaining this driver? I haven't seen
> an ack from him since 2016. As we nowadays try to keep the MAINTAINERS
> up-to-date so should we remove him?
Yeah, feel free to remove him. I can post a patch if needed.
Regards
Stanislaw
