Search Linux Wireless

Re: [PATCH] wifi: rt2x00: fix rt2800 watchdog function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 19 Oct 2023 07:00:30 +0000, Kalle Valo wrote:

>Shiji Yang <yangshiji66@xxxxxxxxxxx> wrote:
>
>> The watchdog function is broken on rt2800 series SoCs. This patch
>> fixes the incorrect watchdog logic to make it work again.
>> 
>> 1. Update current wdt queue index if it's not equal to the previous
>>    index. Watchdog compares the current and previous queue index to
>>    judge if the queue hung.
>> 2. Make sure hung_{rx,tx} 'true' status won't be override by the
>>    normal queue. Any queue hangs should trigger a reset action.
>> 3. Clear the watchdog counter of all queues before resetting the
>>    hardware. This change may help to avoid the reset loop.
>> 4. Change hang check function return type to bool as we only need
>>    to return two status, yes or no.
>> 
>> Signed-off-by: Shiji Yang <yangshiji66@xxxxxxxxxxx>
>
>Is this patch ok to take?


Hi! I think it's ready. I've been testing it for a few weeks.

>
>-- 
>https://patchwork.kernel.org/project/linux-wireless/patch/TYAP286MB0315BC1D83D31154924F0D39BCD1A@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
>
>https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>

Regards,
Shiji Yang



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux