Search Linux Wireless

Re: [PATCH/RFT] iwlagn: fix RX skb alignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2008-11-19 at 14:24 +0200, Tomas Winkler wrote:
> On Wed, Nov 19, 2008 at 1:40 PM, Johannes Berg
> <johannes@xxxxxxxxxxxxxxxx> wrote:
> > On Wed, 2008-11-19 at 11:21 +0200, Tomas Winkler wrote:
> >
> >> > Indeed. One would seem to be the buffer list itself, which also needs to
> >> > fit within a 40-bit mask with 256 alignment (rxq->bd), the rb_stts needs
> >> > 16-byte alignment which probably is always satisfied, but I'm not sure,
> >> > you'll need to research the alignment guarantees.
> >>
> >> Note these are allocated using persistent calls and not kmalloc I hope
> >> at least does are page alignment.
> >
> > Good point. On powerpc at least that uses alloc_pages internally.
> 
> Not sure if if wouldn't be better just work directly with pages in RX?

Well, in theory yes, but it's not possible to have skb->data point to a
separate page rather than a kmalloc area. And while you could allocate
an skb with very little headroom and the rest of the skb data in the
fraglist with pages, mac80211 couldn't handle it.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux