On Wed, Nov 19, 2008 at 2:48 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > [dropping a few CCs] > > On Tue, 2008-11-18 at 16:13 +0200, Tomas Winkler wrote: > >> There are other places with alignment requirement in the driver we >> probably need to address as well. > > Indeed. One would seem to be the buffer list itself, which also needs to > fit within a 40-bit mask with 256 alignment (rxq->bd), the rb_stts needs > 16-byte alignment which probably is always satisfied, but I'm not sure, > you'll need to research the alignment guarantees. Note these are allocated using persistent calls and not kmalloc I hope at least does are page alignment. We have some alignment requirements also on TX side > > Another, different, question: I don't see where the driver tells the > hardware how large the buffers are it allocated. Can you point me to > that? You can switch 4k/8k ampdu but I don't see where you tell the > hardware. in iwl_rx_init rb_size = FH_RCSR_RX_CONFIG_REG_VAL_RB_SIZE_4K .. 8K .. can go up to 16K. This amsdu size (not ampdu) influence the size of RB we choose Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
