Search Linux Wireless

Re: [PATCH/RFT] iwlagn: fix RX skb alignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2008-11-19 at 11:21 +0200, Tomas Winkler wrote:

> > Indeed. One would seem to be the buffer list itself, which also needs to
> > fit within a 40-bit mask with 256 alignment (rxq->bd), the rb_stts needs
> > 16-byte alignment which probably is always satisfied, but I'm not sure,
> > you'll need to research the alignment guarantees.
> 
> Note these are allocated using persistent calls and not kmalloc I hope
> at least does are page alignment.

Good point. On powerpc at least that uses alloc_pages internally.

> We have some alignment requirements also on TX side
> 
> >
> > Another, different, question: I don't see where the driver tells the
> > hardware how large the buffers are it allocated. Can you point me to
> > that? You can switch 4k/8k ampdu but I don't see where you tell the
> > hardware.
> 
> in iwl_rx_init
>  rb_size =
>  FH_RCSR_RX_CONFIG_REG_VAL_RB_SIZE_4K .. 8K .. can go up to 16K.
> This  amsdu size (not ampdu) influence the size of RB we choose

Thanks. Yeah, ampdus are deaggregated already, my mistake.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux