On Mon, 2023-09-18 at 15:29 -0700, Aloka Dixit wrote: > > Alternatively, maybe we should indeed change the prototype again and > > introduce a new struct cfg80211_ap_update that contains only the > > parameters that change? > > > > That feels a bit harder, but really it isn't by that much - in mac80211 > > ieee80211_set_fils_discovery() etc. already take the sub-parameters > > (¶ms->fils_discovery), so not a problem there, and in nl80211 we > > could as well pass struct cfg80211_fils_discovery directly to > > nl80211_parse_fils_discovery() rather than the entire struct > > cfg80211_ap_settings, which wouldn't be a massive change. > > > > > > I think maybe I even prefer the latter if I'm looking at it now, but I'm > > not sure I'm not missing something from earlier discussions on this. > > The second option will take couple of weeks due to current work load. Since you didn't seem to be opposed, I just did the second thing myself now, it wasn't really hard. :) johannes
