On 8/16/2023 11:38 AM, Jeff Johnson wrote:
On 7/27/2023 10:40 AM, Aloka Dixit wrote:
v8: Patches #1, #2 are new in this version which allow resetting
the interval to 0 once set to non-zero which was not possible earlier.
No functional changes to the remaining three patches from v7 here:
https://patchwork.kernel.org/project/linux-wireless/list/?series=693804&state=%2A&archive=both
v7: Resolved conflicts with MLO code changes.
FILS discovery and unsolicited broadcast probe response transmissions
are configured as part of NL80211_CMD_START_AP. The configurations
may get changed whenever there is a change in beacon, e. g. when
a channel switch operation completes the new templates will be sent
by the userspace which reflects the new channel bandwidth. Process the
attributes for these features in NL80211_CMD_SET_BEACON as well.
- Replace the check for interval (for both features) with a new flag
'update' which is set only when the userspace requests an update to
the configuration. This allows the interval to be set to 0 and
templates deleted which wasn't allowed earlier as the attributes got
processed only if the interval was non-zero.
- Modify the local variable in nl80211_set_beacon() and input parameter
to rdev_change_beacon() from type struct cfg80211_beacon_data to
type struct cfg80211_ap_settings to support the new processing.
- Modify ieee80211_change_beacon() to reflect the new input parameter
type.
- Modify driver specific functions pointed by change_beacon to reflect
the new input parameter type.
- Add the missing implementation in nl80211 and mac80211 to process
FILS discovery and unsolicited broadcast probe response configurations.
Aloka Dixit (5):
wifi: nl80211: fixes to FILS discovery updates
wifi: mac80211: fixes in FILS discovery updates
wifi: cfg80211: modify prototype for change_beacon
wifi: nl80211: additions to NL80211_CMD_SET_BEACON
wifi: mac80211: additions to change_beacon()
drivers/net/wireless/ath/ath6kl/cfg80211.c | 4 +-
drivers/net/wireless/ath/wil6210/cfg80211.c | 3 +-
.../broadcom/brcm80211/brcmfmac/cfg80211.c | 4 +-
.../net/wireless/marvell/mwifiex/cfg80211.c | 3 +-
.../wireless/microchip/wilc1000/cfg80211.c | 4 +-
.../net/wireless/quantenna/qtnfmac/cfg80211.c | 4 +-
.../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 6 +-
include/net/cfg80211.h | 6 +-
include/uapi/linux/nl80211.h | 11 +-
net/mac80211/cfg.c | 102 ++++++++++--------
net/wireless/nl80211.c | 47 ++++++--
net/wireless/rdev-ops.h | 2 +-
net/wireless/trace.h | 54 +++++-----
13 files changed, 159 insertions(+), 91 deletions(-)
base-commit: b2090d93d4b6f1c72a9793d5a171806b8468b7cb
for the series:
Reviewed-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
Thanks for the review!