On 8/17/2023 11:04 AM, Aloka Dixit wrote:
On 8/16/2023 11:38 AM, Jeff Johnson wrote:
On 7/27/2023 10:40 AM, Aloka Dixit wrote:
v8: Patches #1, #2 are new in this version which allow resetting
the interval to 0 once set to non-zero which was not possible earlier.
No functional changes to the remaining three patches from v7 here:
https://patchwork.kernel.org/project/linux-wireless/list/?series=693804&state=%2A&archive=both
v7: Resolved conflicts with MLO code changes.
FILS discovery and unsolicited broadcast probe response transmissions
are configured as part of NL80211_CMD_START_AP. The configurations
may get changed whenever there is a change in beacon, e. g. when
a channel switch operation completes the new templates will be sent
by the userspace which reflects the new channel bandwidth. Process the
attributes for these features in NL80211_CMD_SET_BEACON as well.
- Replace the check for interval (for both features) with a new flag
'update' which is set only when the userspace requests an update to
the configuration. This allows the interval to be set to 0 and
templates deleted which wasn't allowed earlier as the attributes got
processed only if the interval was non-zero.
- Modify the local variable in nl80211_set_beacon() and input parameter
to rdev_change_beacon() from type struct cfg80211_beacon_data to
type struct cfg80211_ap_settings to support the new processing.
- Modify ieee80211_change_beacon() to reflect the new input parameter
type.
- Modify driver specific functions pointed by change_beacon to reflect
the new input parameter type.
- Add the missing implementation in nl80211 and mac80211 to process
FILS discovery and unsolicited broadcast probe response configurations.
base-commit: b2090d93d4b6f1c72a9793d5a171806b8468b7cb
for the series:
Reviewed-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
Thanks for the review!
Hello Johannes,
Please review this series.
I know this version is too late to recollect the context of earlier
patches but hopefully following is helpful.
Versions 1 to 7 tried to fix this issue - FILS discovery transmission
stops after CSA. I had tried to fix it in mac80211 which did not set
BSS_CHANGED_FILS_DISCOVERY unless new parameters were sent by user-space.
For v7, you mentioned that while the flag=0 indicates that FILS
configurations did not change, it does not indicate that it got deleted
so the driver should decide depending on the existing configuration and
not depend only on the flag. I have already validated this ath12k patch
which fixes the above issue, without cfg80211 and mac80211 patches in
this series:
https://patchwork.kernel.org/project/linux-wireless/patch/20230905174324.25296-1-quic_alokad@xxxxxxxxxxx/
And I have changed this series to let the user-space give 'interval=0'
as the parameter which was basically a no-op earlier. This way the
transmission can be stopped explicitly and include the additional
processing in the change_beacon from the previous versions which was
anyway required.
Thanks.
