Please see https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_messages > 3. The code is enabled and tested with IW416. > There is no guarantee for other chips. That seems misleading - it's not even enabled for other chips, is it? Or are you saying that there are multiple variants of sd8979, and only one of them is supported?! In that case you need to detect it. Also, it seems like you likely need to detect the firmware version that has the support, not just the hardware? > +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c > @@ -331,6 +331,7 @@ static const struct mwifiex_sdio_device mwifiex_sdio_sd8786 = { > .can_dump_fw = false, > .can_auto_tdls = false, > .can_ext_scan = false, > + .host_mlme = false, probably better to not have all the =false lines that are default anyway? This is the only one enabling it afaict: > static const struct mwifiex_sdio_device mwifiex_sdio_sd8978 = { > @@ -408,6 +413,7 @@ static const struct mwifiex_sdio_device mwifiex_sdio_sd8978 = { > .fw_dump_enh = true, > .can_auto_tdls = false, > .can_ext_scan = true, > + .host_mlme = true, > }; johannes
