> From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > Sent: Wednesday, August 9, 2023 8:23 PM > To: David Lin <yu-hao.lin@xxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx > Cc: Sharvari Harisangam <sharvari.harisangam@xxxxxxx>; Pete Hsieh > <tsung-hsien.hsieh@xxxxxxx> > Subject: [EXT] Re: [PATCH v2] wifi: mwifiex: added code to support host mlme. > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > Please see > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwireless. > wiki.kernel.org%2Fen%2Fdevelopers%2Fdocumentation%2Fsubmittingpatches > %23commit_messages&data=05%7C01%7Cyu-hao.lin%40nxp.com%7C92701a7 > 62acb49fb977608db98d36f73%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0 > %7C0%7C638271806093535337%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4 > wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C > %7C%7C&sdata=9eVhKVmr%2F6NAKODF7zYH5Dvm9bDvdrzJOcZ0FpmGVWI%3 > D&reserved=0 > > > 3. The code is enabled and tested with IW416. > > There is no guarantee for other chips. > > That seems misleading - it's not even enabled for other chips, is it? > > Or are you saying that there are multiple variants of sd8979, and only one of > them is supported?! In that case you need to detect it. > > Also, it seems like you likely need to detect the firmware version that has the > support, not just the hardware? > Sorry. Only enable for IW416. Yes, it needs firmware version 2 to support this feature. > > > +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c > > @@ -331,6 +331,7 @@ static const struct mwifiex_sdio_device > mwifiex_sdio_sd8786 = { > > .can_dump_fw = false, > > .can_auto_tdls = false, > > .can_ext_scan = false, > > + .host_mlme = false, > > probably better to not have all the =false lines that are default anyway? > I followed original code. I will keep this in mind when we create new cfg80211 driver. > This is the only one enabling it afaict: > > > static const struct mwifiex_sdio_device mwifiex_sdio_sd8978 = { @@ > > -408,6 +413,7 @@ static const struct mwifiex_sdio_device > mwifiex_sdio_sd8978 = { > > .fw_dump_enh = true, > > .can_auto_tdls = false, > > .can_ext_scan = true, > > + .host_mlme = true, > > }; > Yes. > johannes
