On Wed, 2023-08-09 at 14:17 +0200, Johannes Berg wrote: > On Wed, 2023-08-09 at 09:57 +0530, Harshitha Prem wrote: > > > > During the crash, the fragment id of that packet was 0 and > > __fls returned a junk value. Hence, it was identified that "__fls" > > would have an undefined behavior if the argument is passed as "0". > > Therefore, add changes to handle the same. > > Umm. That makes it sound like you are surprised by this behaviour of > __fls() and expected something else?! Please go read the documentation, > and then rewrite the commit message. You really shouldn't be surprised > by this. > Also, btw, "Fixes:" tags would be nice for fixes. I'm sure Kalle has brought that up a million times before ;) johannes
