> From: Brian Norris <briannorris@xxxxxxxxxxxx> > Sent: Saturday, July 29, 2023 12:23 AM > To: David Lin <yu-hao.lin@xxxxxxx> > Cc: linux-wireless@xxxxxxxxxxxxxxx; Sharvari Harisangam > <sharvari.harisangam@xxxxxxx>; Pete Hsieh <tsung-hsien.hsieh@xxxxxxx> > Subject: [EXT] Re: [PATCH] wifi: mwifiex: added code to support host mlme. > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > Wait, your company can't afford to have anyone respond to maintainer mail > for years [1], but you can afford to add new features? Crazy. > This feature is needed for WPA3. > [1] > https://lore.kern/ > el.org%2Fall%2F87sf9j3wd1.fsf%40kernel.org%2F&data=05%7C01%7Cyu-hao.li > n%40nxp.com%7C26c1530ca6144dbc4c4e08db8f86f323%7C686ea1d3bc2b4c6 > fa92cd99c5c301635%7C0%7C0%7C638261581991326306%7CUnknown%7CTW > FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV > CI6Mn0%3D%7C3000%7C%7C%7C&sdata=C2ZuAy8NuU5R3DL1Pja2dj4Qqb%2 > Bfyd9g4R4a5ZziKT0%3D&reserved=0 > > On Thu, Jul 27, 2023 at 11:19 PM David Lin <yu-hao.lin@xxxxxxx> wrote: > > > > 1. For station mode first. > > 2. This feature is a must for WPA3. > > 3. The code is tested with IW416. There is no guarantee for other chips. > > ^^ That's not a good sign. > > > Signed-off-by: David Lin <yu-hao.lin@xxxxxxx> > > > drivers/net/wireless/marvell/mwifiex/util.c | 74 ++++ > > 14 files changed, 558 insertions(+), 13 deletions(-) > > > --- a/drivers/net/wireless/marvell/mwifiex/main.c > > +++ b/drivers/net/wireless/marvell/mwifiex/main.c > > @@ -28,6 +28,10 @@ module_param(driver_mode, ushort, 0); > > MODULE_PARM_DESC(driver_mode, > > "station=0x1(default), ap-sta=0x3, station-p2p=0x5, > > ap-sta-p2p=0x7"); > > > > +bool host_mlme; > > +module_param(host_mlme, bool, 0); > > +MODULE_PARM_DESC(host_mlme, "Host MLME support enable:1, > disable:0"); > > + > > I hear Kalle doesn't like module parameters like this. They're a cop out on > properly supporting features (also, see your own commit message). I'd have to > dig through the archives to find the latest advice and rules on this. > > Overall, I'm not enthusiastic about this change. The parameter 'host_mlme' is added to protect original code. It will be disabled as default. > > Brian
