Wait, your company can't afford to have anyone respond to maintainer mail for years [1], but you can afford to add new features? Crazy. [1] https://lore.kernel.org/all/87sf9j3wd1.fsf@xxxxxxxxxx/ On Thu, Jul 27, 2023 at 11:19 PM David Lin <yu-hao.lin@xxxxxxx> wrote: > > 1. For station mode first. > 2. This feature is a must for WPA3. > 3. The code is tested with IW416. There is no guarantee for other chips. ^^ That's not a good sign. > Signed-off-by: David Lin <yu-hao.lin@xxxxxxx> > drivers/net/wireless/marvell/mwifiex/util.c | 74 ++++ > 14 files changed, 558 insertions(+), 13 deletions(-) > --- a/drivers/net/wireless/marvell/mwifiex/main.c > +++ b/drivers/net/wireless/marvell/mwifiex/main.c > @@ -28,6 +28,10 @@ module_param(driver_mode, ushort, 0); > MODULE_PARM_DESC(driver_mode, > "station=0x1(default), ap-sta=0x3, station-p2p=0x5, ap-sta-p2p=0x7"); > > +bool host_mlme; > +module_param(host_mlme, bool, 0); > +MODULE_PARM_DESC(host_mlme, "Host MLME support enable:1, disable:0"); > + I hear Kalle doesn't like module parameters like this. They're a cop out on properly supporting features (also, see your own commit message). I'd have to dig through the archives to find the latest advice and rules on this. Overall, I'm not enthusiastic about this change. Brian
