> From: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
> Sent: Saturday, July 29, 2023 12:48 AM
> To: David Lin <yu-hao.lin@xxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx
> Cc: Sharvari Harisangam <sharvari.harisangam@xxxxxxx>; Pete Hsieh
> <tsung-hsien.hsieh@xxxxxxx>
> Subject: [EXT] Re: [PATCH] wifi: mwifiex: added code to support host mlme.
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On 7/27/2023 11:18 PM, David Lin wrote:
> > 1. For station mode first.
> > 2. This feature is a must for WPA3.
> > 3. The code is tested with IW416. There is no guarantee for other chips.
> >
> > Signed-off-by: David Lin <yu-hao.lin@xxxxxxx>
> > ---
> > .../net/wireless/marvell/mwifiex/cfg80211.c | 327
> +++++++++++++++++-
> > drivers/net/wireless/marvell/mwifiex/cmdevt.c | 2 +-
> > drivers/net/wireless/marvell/mwifiex/decl.h | 12 +
> > drivers/net/wireless/marvell/mwifiex/fw.h | 15 +
> > drivers/net/wireless/marvell/mwifiex/init.c | 3 +
> > drivers/net/wireless/marvell/mwifiex/join.c | 65 +++-
> > drivers/net/wireless/marvell/mwifiex/main.c | 4 +
> > drivers/net/wireless/marvell/mwifiex/main.h | 10 +
> > drivers/net/wireless/marvell/mwifiex/scan.c | 6 +
> > .../net/wireless/marvell/mwifiex/sta_event.c | 17 +-
> > .../net/wireless/marvell/mwifiex/sta_ioctl.c | 1 +
> > drivers/net/wireless/marvell/mwifiex/sta_tx.c | 10 +-
> > .../net/wireless/marvell/mwifiex/uap_cmd.c | 25 ++
> > drivers/net/wireless/marvell/mwifiex/util.c | 74 ++++
> > 14 files changed, 558 insertions(+), 13 deletions(-)
>
> I just did a quick scan to see if anything jumped out at me
>
> ...
>
> > diff --git a/drivers/net/wireless/marvell/mwifiex/fw.h
> > b/drivers/net/wireless/marvell/mwifiex/fw.h
> > index f2168fac95ed..e2827e25ec38 100644
> > --- a/drivers/net/wireless/marvell/mwifiex/fw.h
> > +++ b/drivers/net/wireless/marvell/mwifiex/fw.h
>
> ..
>
> > +#define MWIFIEX_AUTHTYPE_SAE 6
> > +
> > +struct mwifiex_ie_types_sae_pwe_mode {
> > + struct mwifiex_ie_types_header header;
> > + u8 pwe[1];
>
> this jumped out, it is not allowed (unless this really is a 1-element array)
>
> see
> <https://www.ke/
> rnel.org%2Fdoc%2Fhtml%2Fnext%2Fprocess%2Fdeprecated.html%23zero-lengt
> h-and-one-element-arrays&data=05%7C01%7Cyu-hao.lin%40nxp.com%7C25c5
> 6f0fae1f476485d308db8f8a6cbd%7C686ea1d3bc2b4c6fa92cd99c5c301635%7
> C0%7C0%7C638261596917903672%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM
> C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%
> 7C%7C%7C&sdata=x8gOxfAcEpZY9Qg5%2B%2B7gz7OGUp9InUIoRnyb%2BGJyj
> Ss%3D&reserved=0>
>
> should just be u8 pwe[];
>
> make sure any code that uses sizeof(struct
> mwifiex_ie_types_sae_pwe_mode) accounts for the u8 being removed from
> the struct
>
>
> > +} __packed;
Yes, I just used the latest checkpatch.sh, this error happened. I will correct more comments and fix this issue in PATCH V2. Sorry and Thanks.
