On Wed, 2008-11-05 at 13:38 -0200, Herton Ronaldo Krzesinski wrote: > > > WARNING: line over 80 characters > > > #138: FILE: drivers/net/wireless/rtl8187_dev.c:475: > > > + if ((le16_to_cpu(ieee80211hdr->seq_ctrl) & 0xFFF) > > > == seq_no) > > Ops, I forgot to run checkpatch.pl here, will run and fix it when I submit > next patch. I wouldn't worry about lines > 80 chars too much, breaking this down wouldn't make more readable but less so, in my opinion. I tend to ignore that rule where it makes the code unreadable :) > > Besides, that line looks wrong? the lowest 4 bits are teh fragment > > number. > > It's intended, because the hardware instead of reporting just the sequence > number in its 12 bits is reporting fragment number + sequence number, this is > a workaround. Ah. A comment might be appropriate that "seq_no" doesn't actually contain the sequence number? johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
