On Wednesday 05 November 2008 09:29:12 Johannes Berg wrote: > On Tue, 2008-11-04 at 14:31 -0800, Larry Finger wrote: > > Herton Ronaldo Krzesinski wrote: > > > Realtek 8187B has a receive command queue to feedback beacon interrupt > > > and transmitted packet status. Use it to feedback mac80211 about status > > > of transmitted packets. Unfortunately in the course of testing I found > > > that the sequence number reported by hardware includes entire sequence > > > control in a 12 bit only field, so a workaround is done to check only > > > lowest bits. > > > > > > Signed-off-by: Herton Ronaldo Krzesinski <herton@xxxxxxxxxxxxxxx> > > > > Tested-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > > > > > > Quilt shows the following warning: > > > > Warning: trailing whitespace in lines 438,468 of > > drivers/net/wireless/rtl8187_dev.c > > > > scripts/checkpatch shows the following: > > > > WARNING: line over 80 characters > > #138: FILE: drivers/net/wireless/rtl8187_dev.c:475: > > + if ((le16_to_cpu(ieee80211hdr->seq_ctrl) & 0xFFF) > > == seq_no) Ops, I forgot to run checkpatch.pl here, will run and fix it when I submit next patch. > > Besides, that line looks wrong? the lowest 4 bits are teh fragment > number. It's intended, because the hardware instead of reporting just the sequence number in its 12 bits is reporting fragment number + sequence number, this is a workaround. > > johannes -- []'s Herton -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
