Hi Paul,
On 7/24/22 23:00, Matwey V. Kornilov wrote:
> Hello,
>
> I've just found that the following commit
>
> 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
>
> breaks the ethernet on my Lex 3I380CW (Atom E3845) motherboard. The board is
> equipped with dual Intel I211 based 1Gbps copper ethernet.
>
> Before the commit I see the following:
>
> igb 0000:01:00.0: added PHC on eth0
> igb 0000:01:00.0: Intel(R) Gigabit Ethernet Network Connection
> igb 0000:01:00.0: eth0: (PCIe:2.5Gb/s:Width x1) 4c:02:89:10:02:e4
> igb 0000:01:00.0: eth0: PBA No: FFFFFF-0FF
> igb 0000:01:00.0: Using MSI-X interrupts. 2 rx queue(s), 2 tx queue(s)
> igb 0000:02:00.0: added PHC on eth1
> igb 0000:02:00.0: Intel(R) Gigabit Ethernet Network Connection
> igb 0000:02:00.0: eth1: (PCIe:2.5Gb/s:Width x1) 4c:02:89:10:02:e5
> igb 0000:02:00.0: eth1: PBA No: FFFFFF-0FF
> igb 0000:02:00.0: Using MSI-X interrupts. 2 rx queue(s), 2 tx queue(s)
>
> while when the commit is applied I see the following:
>
> igb 0000:01:00.0: added PHC on eth0
> igb 0000:01:00.0: Intel(R) Gigabit Ethernet Network Connection
> igb 0000:01:00.0: eth0: (PCIe:2.5Gb/s:Width x1) 4c:02:89:10:02:e4
> igb 0000:01:00.0: eth0: PBA No: FFFFFF-0FF
> igb 0000:01:00.0: Using MSI-X interrupts. 2 rx queue(s), 2 tx queue(s)
> igb: probe of 0000:02:00.0 failed with error -2
>
> Please note, that the second ethernet initialization is failed.
>
>
> See also: http://www.lex.com.tw/products/pdf/3I380A&3I380CW.pdf
Yes some boards use more then 1 clk for the ethernet and do not take
care of enabling/disabling the clk in their ACPI.
As Pierre-Louis mentioned already the disabling of the clocks is necessary
to make 100-s of different (tablet) models suspend properly.
Unfortunately this is known to break ethernet on some boards. As a workaround
we use DMI quirks on those few boards to keep the clocks enabled there, see:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/platform/x86/pmc_atom.c#n381
If you can submit a patch adding your board to this DMI table, then I will
merge it and get it on its way to Linus Torvalds asap.
If you instead want me to write the patch for you, please run:
sudo dmidecode > dmidecode.txt
And attach the generated dmidecode.txt file to your next email.
Regards,
Hans
