пн, 25 июл. 2022 г. в 20:08, Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>: > > > > On 7/24/22 16:00, Matwey V. Kornilov wrote: > > Hello, > > > > I've just found that the following commit > > > > 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL") > > > > breaks the ethernet on my Lex 3I380CW (Atom E3845) motherboard. The board is > > equipped with dual Intel I211 based 1Gbps copper ethernet. > > It's not going to be simple, it's 4 yr old commit that fixes other > issues with S0i3... Additionally, it seems that the issue appears only when CONFIG_IGB=m is used. When CONFIG_IGB=y then both ethernets are initialized correctly. However, most (if not all) kernel configs in Linux distros use CONFIG_IGB=m > > > > > Before the commit I see the following: > > > > igb 0000:01:00.0: added PHC on eth0 > > igb 0000:01:00.0: Intel(R) Gigabit Ethernet Network Connection > > igb 0000:01:00.0: eth0: (PCIe:2.5Gb/s:Width x1) 4c:02:89:10:02:e4 > > igb 0000:01:00.0: eth0: PBA No: FFFFFF-0FF > > igb 0000:01:00.0: Using MSI-X interrupts. 2 rx queue(s), 2 tx queue(s) > > igb 0000:02:00.0: added PHC on eth1 > > igb 0000:02:00.0: Intel(R) Gigabit Ethernet Network Connection > > igb 0000:02:00.0: eth1: (PCIe:2.5Gb/s:Width x1) 4c:02:89:10:02:e5 > > igb 0000:02:00.0: eth1: PBA No: FFFFFF-0FF > > igb 0000:02:00.0: Using MSI-X interrupts. 2 rx queue(s), 2 tx queue(s) > > > > while when the commit is applied I see the following: > > > > igb 0000:01:00.0: added PHC on eth0 > > igb 0000:01:00.0: Intel(R) Gigabit Ethernet Network Connection > > igb 0000:01:00.0: eth0: (PCIe:2.5Gb/s:Width x1) 4c:02:89:10:02:e4 > > igb 0000:01:00.0: eth0: PBA No: FFFFFF-0FF > > igb 0000:01:00.0: Using MSI-X interrupts. 2 rx queue(s), 2 tx queue(s) > > igb: probe of 0000:02:00.0 failed with error -2 > > > > Please note, that the second ethernet initialization is failed. > > > > > > See also: http://www.lex.com.tw/products/pdf/3I380A&3I380CW.pdf -- With best regards, Matwey V. Kornilov