Hi Arend, others, ------- Original Message ------- On Monday, June 13th, 2022 at 20:50, Danny van Heumen <danny@xxxxxxxxxxxxxxxxx> wrote: > [..] > > > > You should send a proper patch to the linux-wireless list, ie. not in an > > attachment but the commit message and patch diff in plain text email > > message. Please refer to [1] for guidelines. Done. (Sent as separate email not part of this thread.) > [..] > I have tried to reduce/remove the probe-logic in `.reset`, but I can simply not reach that logic reliably (or at all atm), so I cannot test even basic simplifications of the hardware-reset logic. I have not made progress concerning the reduced logic in '.reset'. I will not attempt this any further as I do not have the right circumstances to test this properly. > > > Regards, > > Arend > > > > [1] > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches > > > Another question: > > `BRCMF_FW_DEF(43456, "brcmfmac43456-sdio");` > > This line defines IIUC that a firmware-binary exists. However, there is another macro that defines both the firmware-binary and the clm_blob binary. AFAIK, BCM4345/9 (brcmfmac43456-sdio) supports loading a *.clm_blob file. So I suppose the line should be: > > `BRCMF_FW_CLM_DEF(43456, "brcmfmac43456-sdio");` > > Does this really matter? Should I also submit a patch for this? This is still an open question to me: from what I can tell, 'brcmfmac43456-sdio.clm_blob' loads correctly even though the macro does not define it. So this may concern certain specific use cases. Regards, Danny
