Hi Arend, ------- Original Message ------- On Monday, June 13th, 2022 at 19:32, Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx> wrote: > [..] > > What would be the next steps? > > > You should send a proper patch to the linux-wireless list, ie. not in an > attachment but the commit message and patch diff in plain text email > message. Please refer to [1] for guidelines. Thanks. Will do. > I reinstated SDIO card in my test setup so I can test your patch. That's great! I have tried to reduce/remove the probe-logic in `.reset`, but I can simply not reach that logic reliably (or at all atm), so I cannot test even basic simplifications of the hardware-reset logic. > Regards, > Arend > > [1] > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches Another question: `BRCMF_FW_DEF(43456, "brcmfmac43456-sdio");` This line defines IIUC that a firmware-binary exists. However, there is another macro that defines both the firmware-binary and the clm_blob binary. AFAIK, BCM4345/9 (brcmfmac43456-sdio) supports loading a *.clm_blob file. So I suppose the line should be: `BRCMF_FW_CLM_DEF(43456, "brcmfmac43456-sdio");` Does this really matter? Should I also submit a patch for this? Thanks so far, Danny
