On Mon, 2008-10-20 at 01:55 -0700, Luis R. Rodriguez wrote: > On Mon, Oct 20, 2008 at 1:47 AM, Sujith <Sujith.Manoharan@xxxxxxxxxxx> wrote: > > Johannes Berg wrote: > > > On Mon, 2008-10-20 at 01:35 -0700, Luis R. Rodriguez wrote: > > > > > > > >> + * @is_part_ampdu: set to indicate that the wireless core should should > > > > >> + * treat this frame as part of an AMPDU > > > > > > > > > > I thought we said we could keep the flag instead of moving to the skb > > > > > here? > > > > > > > > That was just because the changes required to add this was too much > > > > for 2.6.27 but since we don't care about this fix in 2.6.27 we can do > > > > whatever is needed to fix this properly. > > > > > > Right, but adding random stuff into skb isn't really "properly" imho. > > > And we don't really need this afaict. > > > > > > > Sorry, just saw that Tomas had fixed it by setting the flag in ieee80211_tx_h_sequence(). > > Will fix that. > > No that was a hack too, this was to minimize code changes for 2.6.27 as well. Well the fact that it's in tx_h_sequence is a bit weird, but we should be able to get around not using an extra bit in skb I think. Especially for this since it's only really between the driver and mac80211, and after a requeue the ampdu status might actually change. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
