On Mon, Oct 20, 2008 at 1:45 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Mon, 2008-10-20 at 01:35 -0700, Luis R. Rodriguez wrote: > >> >> + * @is_part_ampdu: set to indicate that the wireless core should should >> >> + * treat this frame as part of an AMPDU >> > >> > I thought we said we could keep the flag instead of moving to the skb >> > here? >> >> That was just because the changes required to add this was too much >> for 2.6.27 but since we don't care about this fix in 2.6.27 we can do >> whatever is needed to fix this properly. > > Right, but adding random stuff into skb isn't really "properly" imho. > And we don't really need this afaict. Agreed -- which is why I was suggesting we should consider using skb->do_not_fragment instead. Although I didn't finish complete review to ensure that is the only reason we need this. That is a more generic flag. Thoughts? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
