On Thu, Oct 9, 2008 at 11:52 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Wed, 2008-10-08 at 14:38 +0200, Tomas Winkler wrote: > >> >> > Also, keep in mind that address 2 is _never_ used at all anyway >> > >> >> This is not correct we always use first 2 pointers. First for tx command >> >> second for the actual packet. >> > >> > Ok so you use two. >> >> My only point is just to make sure that you understand that __never__ >> is not correct > > Right, sorry, I really should have checked. > >> > Writing three words in total. I strongly suggest that >> > you have WAY more trouble in iwlwifi than an imagined performance issue >> > coming from a corrected and understandable struct layout. >> >> You are rally trying breaking into open doors Currently I'm more >> concern with correctness then performance so I wanted to rise >> hopefully all issues. >> I'm testing your layout it's work so far in my home setup. I'm on >> holidays till EOW so I will be able to give it some more stress in Lab >> only next week. > > Sure, that's fine, I can't really see what can go wrong but testing is > always good. Not everything can be seen I hoped you've learned that already. People tend to only test their code whether it fixes the particular problem they want to fix not seeing the collateral bugs they are creating on the way. But there hundred of books about the subject. It just seemed to me that for some reason you preferred > keeping the pair-layout and complicating the code? Don't take assumptions, people communication is most flawed protocol. Tomas Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
