Search Linux Wireless

Re: [PATCH] iwlwifi: get rid of IWL_{GET,SET}_BITS crap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2008-10-07 at 21:28 +0200, Tomas Winkler wrote:

> > And please keep the 10 pairs -> 20 addresses, it's a lot easier to
> > understand :)

> I don't like on this solution two things one is that it 32 bit
> variables sits on unaligned address

That doesn't matter at all since it's packed, and the bitwise accesses
you did previously are way less efficient.

>  and second
> it doesn't mach HW description which defines this as  descriptor couple

Then tell the HW engineers to fix the HW docs. It makes no sense at all
to say this is 10 pairs rather than 20 single ones if there's nothing
that uses a pair, the whole thing entirely uses single entries in the
numbering etc.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux